Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source File: add data presence validation for HTTPS for check_connection #17504

Merged
merged 3 commits into from
Oct 3, 2022
Merged

🐛 Source File: add data presence validation for HTTPS for check_connection #17504

merged 3 commits into from
Oct 3, 2022

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Oct 3, 2022 •
edited
Loading

What

Resolves: https://github.com/airbytehq/alpha-beta-issues/issues/224

How

  • added additional check for downloaded csv with storage == HTTPS provided URLs.
  • added unit_test to cover the case

🚨 User Impact 🚨

No impact is expected.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@bazarnov bazarnov self-assigned this Oct 3, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 3, 2022
@bazarnov bazarnov changed the title 🐛 Source File: add data presence validation for HTTPS 🐛 Source File: add data presence validation for HTTPS for check_connection Oct 3, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 3, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented Oct 3, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3174823254
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3174823254
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       275     42    85%
source_file/source.py        60     35    42%
---------------------------------------------
TOTAL                       337     77    77%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/source.py        60      0   100%
source_file/__init__.py       2      0   100%
source_file/client.py       275     34    88%
---------------------------------------------
TOTAL                       337     34    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 26 passed, 1 skipped in 61.53s (0:01:01) ===================

@bazarnov
Copy link
Collaborator Author

bazarnov commented Oct 3, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/3174963666


Connector Did it publish? Were definitions generated?
connectors/source-file ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov merged commit 8c4b61c into master Oct 3, 2022
@bazarnov bazarnov deleted the baz/source-file-fix-drropbox-public-url-check branch October 3, 2022 15:44
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Oct 5, 2022
Merged
@grubberr grubberr mentioned this pull request Oct 19, 2022
Merged
14 tasks
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@bazarnov @jhammarstedt
🐛 Source File: add data presence validation for HTTPS for `check_co…
c26ff15 
…nnection` (airbytehq#17504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubberr grubberr grubberr approved these changes

@davydov-d davydov-d davydov-d approved these changes

@arsenlosenko arsenlosenko arsenlosenko approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees

@bazarnov bazarnov

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/file team/connectors-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bazarnov @grubberr @davydov-d @arsenlosenko @lazebnyi @octavia-squidington-iv @octavia-squidington-iii